feat(rest) : Endpoint for export SBOM at project detail page #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farooq-Fateh-Aftab
force-pushed
the
feat/exportSbomProjectDetail
branch
from
fff9a51 to
509b2b0
Compare
GMishx
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
GMishx
added
needs code review
needs general test
GMishx
requested changes
Mar 11, 2025
Comment on lines
+450
to
+456
| if (RequestStatus.FAILED_SANITY_CHECK.equals(status)) { | ||
| bomString = "{\"status\": \"" + status.name() + "\"}"; | ||
| } else if (RequestStatus.ACCESS_DENIED.equals(status)) { | ||
| bomString = "{\"status\": \"" + status.name() + "\", \"message\": \"" + SW360Constants.SBOM_IMPORT_EXPORT_ACCESS_USER_ROLE + "\"}"; | ||
| } else if (RequestStatus.FAILURE.equals(status)) { | ||
| bomString = "{\"status\": \"" + status.name() + "\", \"message\": \"" + summary.getMessage() + "\"}"; | ||
| } else { |
There was a problem hiding this comment.
These states should cause an exception and not return a JSON with a normal 200 response code. Please throw appropriate exceptions based on the failure state.
Otherwise, as of now, I will get a JSON saying {"status": "ACCESS_DENIED", "message": "..."} and will assume it is a CDX SBOM unless I open it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2858
Suggest Reviewer
How To Test?
Request Type : get
bomType : json or xml
withSubProject : true or false
module= sbom
projectId : project id
url:
http://localhost:8080/resource/api/reports?module=sbom&projectId=c2b4ced4c19ebb07d63039c5d501800a&withSubProject=true&bomType=json
Checklist
Must: